Skip to content

Conversation

@charvimehradu
Copy link
Collaborator

Pull Request for Issue #6

Summary of Changes

Refactor Joomla\AI\Response\Response to extend Joomla\Http\Response (PSR‑7 compliant)

Testing Instructions

Documentation Changes Required

@Hackwar Hackwar changed the base branch from main to feature/ai August 21, 2025 18:55
@Hackwar Hackwar changed the base branch from feature/ai to main August 21, 2025 18:55
@Hackwar
Copy link
Collaborator

Hackwar commented Aug 21, 2025

This looks good, but I think you want to aim that at the feature/ai branch. And then you might want to push the feature/ai branch again as 4.x-dev and switch the default branch to that one. Then we can delete the main branch and all the other branches which you don't need anymore. Last but not least, the documentation would be important. 😉

@charvimehradu charvimehradu changed the base branch from main to 4.x-dev August 22, 2025 05:07
@charvimehradu
Copy link
Collaborator Author

charvimehradu commented Aug 22, 2025

Hi,
I have merged main into feature/ai so that all changes are combined. I have also pushed the branch as 4.x-dev. My focus is on the documentation now.
@bembelimen since I don’t have admin rights on the repo, I can’t change the default branch or delete main. Could you please set 4.x-dev as the default branch and delete the old main branch.
Thanks!

@ditsuke
Copy link

ditsuke commented Aug 22, 2025

Hi, I have merged main into feature/ai

I think you mean you've merged feature/ai into main? Anyways could you open a PR with feature/ai changes towards upstream main so AI changes can be reviewed in isolation in a pull request?

@Hackwar
Copy link
Collaborator

Hackwar commented Aug 22, 2025

@bembelimen seems to already have done the branch changes. Otherwise I would have helped out.

@ditsuke No, @charvimehradu is correct that the feature/ai branch is basically the new main branch and that we have to rename it to 4.x-dev to eventually release it as a framework package.

@Hackwar
Copy link
Collaborator

Hackwar commented Aug 22, 2025

@charvimehradu please delete all branches which you don't need anymore. :-)

@charvimehradu
Copy link
Collaborator Author

@ditsuke Just to clarify, we actually merged main into feature/ai to keep all the implementation in the main branch only now (feature/ai is now essentially the new main branch)

@Hackwar I have deleted all unnecessary branches except for this one and can proceed with merging it if you approve.

@Hackwar
Copy link
Collaborator

Hackwar commented Aug 22, 2025

Fine with me. You should also go through the phpstan reportings at some point and we will have to eventually convert your tests to run in phpunit.

@charvimehradu charvimehradu merged commit fdad96a into 4.x-dev Aug 22, 2025
4 of 12 checks passed
@charvimehradu charvimehradu deleted the update-resposne-class branch August 22, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants