-
-
Notifications
You must be signed in to change notification settings - Fork 4
Update Response class to implement PSR7s ResponseInterface #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This looks good, but I think you want to aim that at the feature/ai branch. And then you might want to push the feature/ai branch again as 4.x-dev and switch the default branch to that one. Then we can delete the main branch and all the other branches which you don't need anymore. Last but not least, the documentation would be important. 😉 |
|
Hi, |
I think you mean you've merged feature/ai into main? Anyways could you open a PR with feature/ai changes towards upstream |
|
@bembelimen seems to already have done the branch changes. Otherwise I would have helped out. @ditsuke No, @charvimehradu is correct that the feature/ai branch is basically the new main branch and that we have to rename it to 4.x-dev to eventually release it as a framework package. |
|
@charvimehradu please delete all branches which you don't need anymore. :-) |
|
Fine with me. You should also go through the phpstan reportings at some point and we will have to eventually convert your tests to run in phpunit. |
Pull Request for Issue #6
Summary of Changes
Refactor Joomla\AI\Response\Response to extend Joomla\Http\Response (PSR‑7 compliant)
Testing Instructions
Documentation Changes Required